https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO/issues/10#30
Merged
tannewt merged 7 commits intoadafruit:masterfrom May 18, 2018
Merged
Conversation
added 2 commits
May 15, 2018 15:14
tannewt
requested changes
May 17, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
THanks for picking this up. A couple comments to simplify things.
simpleio.py
Outdated
Member
There was a problem hiding this comment.
Simpler to do def __init__(self, pin, **kwargs):
simpleio.py
Outdated
Member
There was a problem hiding this comment.
Please copy the docs here. Directing elsewhere doesn't simplify the docs.
Author
|
ok, fixed all of your comments. again, tested to make sure python doesn't fail. |
Don't mention switch methods which are implementation details.
tannewt
approved these changes
May 18, 2018
Member
|
Thanks @apatt ! |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 10, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#5 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#4 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#4 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 0.9.2 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#15 from kattni/api-doc-fix > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#14 from kattni/busdevice-fix > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#13 from adafruit/revert-8-pypi > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#12 from adafruit/revert-9-pypi-fix > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#11 from adafruit/revert-10-pypi-fix > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#10 from kattni/pypi-fix > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#9 from kattni/pypi-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.2.0 from 3.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_HID#26 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.2.0 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#9 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#31 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#30 from apatt/master > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#28 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.2.0 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_Waveform#3 from sommersoft/new_docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to test that the parameter passing works as expected and that there are not python errors, but I don't know to confirm the underlying functions (switch_to_input and switch_to_output) functions work as expected.