bitcount argument to shift_out() #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Jun 27, 2019
Member
brentru
left a comment
brentru
left a comment
There was a problem hiding this comment.
Thanks for adding this PR, requesting two small changes...
You'll also need to fix some of the PyLint errors to pass the Travis check: https://travis-ci.com/adafruit/Adafruit_CircuitPython_SimpleIO/builds/117075982#L613
Member
|
@iraytrace Thanks for adding the exception. I can't merge this until the PyLint check for Travis passes (pylint log here: https://travis-ci.com/adafruit/Adafruit_CircuitPython_SimpleIO/builds/117231893#L556). |
Member
|
LGTM! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 16, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.6.0 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#45 from docmollo/docs_wpa2_wifimgr Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.0.5 from 3.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#43 from dastels/master Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#9 from brentru/patch-generate-cursor Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 1.0.1 from v1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Hue#8 from NanoDano/patch-2 > Merge pull request adafruit/Adafruit_CircuitPython_Hue#7 from NanoDano/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#41 from iraytrace/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MiniMQTT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow arbitrary bit count to be handled by shift_out(). Default parameter value preserves old behavior. Note this does fail when bitcount > 2^31