fix for bug prevening retry code in Star Fragment Lamp ( issue #2444)#2445
Open
jdimpson wants to merge 1 commit intoadafruit:mainfrom
Open
fix for bug prevening retry code in Star Fragment Lamp ( issue #2444)#2445jdimpson wants to merge 1 commit intoadafruit:mainfrom
jdimpson wants to merge 1 commit intoadafruit:mainfrom
Conversation
jdimpson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change corrects the bug described in issue #2444. Specifically, it enables the intended behavior of the retry code in
get_request()by passing a reference to code as thepingargument, rather than the output of the code. This means that the code will be retried as needed inget_request(), rather than tried only once.Fixes #2444.