Draft
Conversation
brentru
approved these changes
Aug 14, 2025
Member
brentru
left a comment
brentru
left a comment
There was a problem hiding this comment.
Tyeth and I went over this over slack, all changes OK 🏁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to solve a head scratcher. We're likely to want to support a few boards that have their board define as a plain ESP module, like the DFRobot C3 uses ESP32C3_DEV.
See espressif/arduino-esp32#6883 (comment)
Currently it would be a first come first served, but I have a plan... We add a boards.local.txt or platform.local.txt in wippersnapper that provides an extra define for those kinds of boards. We effectively use the extra_flags or board.defines to define -DWS_DFROBOT_ESP32C3, and have a similar entry in platformIO.ini
I've added a new argument to ci-arduino/build-platforms.py for
--boards-local-txtwhich can take an optional file location (or current working directory default), and will attempt to copy that into the correct platform folder after installing the platform.adafruit/ci-arduino@ci-wippersnapper...ci-wippersnapper-boards-local-txt
Matching tooling PR:
adafruit/ci-arduino#217