Skip to content

fix(demo): switch adapter based on defines, add PICO_CYW43_SUPPORTED#868

Draft
tyeth wants to merge 1 commit intomigrate-api-v2from
add-sleep-mode-network-defines
Draft

fix(demo): switch adapter based on defines, add PICO_CYW43_SUPPORTED#868
tyeth wants to merge 1 commit intomigrate-api-v2from
add-sleep-mode-network-defines

Conversation

@tyeth
Copy link
Member

@tyeth tyeth commented Feb 20, 2026

Currently you cannot build using platformio offline mode for Wi-Fi and non Wi-Fi adapters without manually changing the code base.

This PR facilitates not having to do that by checking suitable network defines on Wi-Fi enabled boards, and then picking the WiFi or non WiFi adapter.

Found issue moving between Pico2w and metroRP2350 when testing the sleep mode PR.

The CYW43 included with pico and rm2 modules has a specific define that we can track too, so the network adaptor has been augmented with this.

@brentru
Copy link
Member

brentru commented Feb 20, 2026

@tyeth Please add more information into this PR such as:

  • What problem does this solve, exactly?
  • Behavior before the define (you can describe it, logs are optional)
  • Behavior after the define inclusion

@tyeth
Copy link
Member Author

tyeth commented Feb 20, 2026

@tyeth Please add more information into this PR such as:

  • What problem does this solve, exactly?
  • Behavior before the define (you can describe it, logs are optional)
  • Behavior after the define inclusion

👍 Done

@brentru brentru self-requested a review February 20, 2026 16:12
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth Perfect explanation, approved. This is currently a draft, please merge in as soon as you test so we can merge the main PR.

Base automatically changed from add-mode-sleep to migrate-api-v2 February 20, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants