Open
Conversation
Member
Author
|
@tyeth in addition to reviewing, could you test on an ESP32 or ESP32-x platform to ensure the F() macro changes didn't introduce any unusual behavior on the Serial? |
Member
Author
|
So this now works? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request reduces the ESP8266 build's size by -34.1%.
Changes:
F()macro to store string literals in Flash (PROGMEM) instead of RAM. This saves precious RAM on memory-constrained ESP8266 devices.WS_DEBUG_PRINTVAR/PRINTLNVARfor variables on this platform.PROGMEMmacro introduced indisplay/for storing icons and splash screen assetsBuild Size Comparison
mainbranch:This branch:
Addresses:
#841 (needs fwd port to v2 after this PR is in)
#862