fix: list supported boards when BOARD is missing - #401
Open
giri256 wants to merge 1 commit into
Open
Conversation
Signed-off-by: p1 <giridharpavan593@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #392
Commit
2d68ec5moved board-specific configuration earlier in the Makefile and removed the existing board validation block. As a result, running baremakereaches the MCU selector with an emptyMCU_SUB_VARIANTand reportsSub Variant is unknowninstead of showing the supported boards.This restores validation before
board.mkis loaded. The supported list is derived from actualsrc/boards/*/board.mkfiles, so it stays current as boards are added or removed. Missing and invalidBOARDvalues now both produce actionable output and preserve a nonzero exit.Verification with GNU Make 4.3:
makelists all 49 supported boards and exits withBOARD not definedmake BOARD=not_a_boardlists the same choices and exits withInvalid BOARD specifiedmake -n BOARD=feather_nrf52840_express cleanmake -n BOARD=feather_nrf52832 clean