Skip to content

Print a warning for repos without descriptions #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Print a warning for repos without descriptions #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8f505f
circuitpython_libraries.py: Don't error if open_prs is empty
jepler Aug 9, 2020
3ad7fb4
validators: Report repos with missing descriptions
jepler Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions adabot/circuitpython_libraries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,13 +230,14 @@ def run_library_checks(validators, bundle_submodules, latest_pylint, kw_args):
int(pr_sort_re.search(pr).group(1)) for pr in lib_insights["open_prs"]
if pr_sort_re.search(pr) is not None
]
output_handler(
" * {0} open pull requests (Oldest: {1}, Newest: {2})".format(
len(lib_insights["open_prs"]),
max(open_pr_days),
max((min(open_pr_days), 1)) # ensure the minumum is '1'
if len(lib_insights["open_prs"]) != 0:
output_handler(
" * {0} open pull requests (Oldest: {1}, Newest: {2})".format(
len(lib_insights["open_prs"]),
max(open_pr_days),
max((min(open_pr_days), 1)) # ensure the minumum is '1'
)
)
)
output_handler("Library updates in the last seven days:")
if len(new_libs) != 0:
output_handler("**New Libraries**")
Expand Down
4 changes: 4 additions & 0 deletions adabot/lib/circuitpython_library_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
" without reference to import errno. See issue " \
"https://github.com/adafruit/circuitpython/issues/1582"
ERROR_MISMATCHED_READTHEDOCS = "Mismatched readthedocs.yml"
ERROR_MISSING_DESCRIPTION = "Missing repository description"
ERROR_MISSING_EXAMPLE_FILES = "Missing .py files in examples folder"
ERROR_MISSING_EXAMPLE_FOLDER = "Missing examples folder"
ERROR_EXAMPLE_MISSING_SENSORNAME = "Example file(s) missing sensor/library name"
Expand Down Expand Up @@ -209,6 +210,9 @@ def validate_repo_state(self, repo):

errors = []

if not repo_fields.get("description"):
errors.append(ERROR_MISSING_DESCRIPTION)

if repo_fields.get("has_wiki"):
errors.append(ERROR_WIKI_DISABLED)

Expand Down