Skip to content

_bleio: remove PacketBuffer.packet_size for 7.0.0 #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dhalbert opened this issue May 4, 2020 · 2 comments
Closed

_bleio: remove PacketBuffer.packet_size for 7.0.0 #2853

dhalbert opened this issue May 4, 2020 · 2 comments
Assignees
Milestone

Comments

@dhalbert
Copy link
Collaborator

dhalbert commented May 4, 2020

In 5.x, after #2799 is merged, PacketBuffer.packet_size is a synonym for PacketBuffer.incoming_packet_length, and is deprecated.

In 6.0.0, it can be dropped, after updating the libraries that use it.

@dhalbert dhalbert added this to the 6.0.0 milestone May 4, 2020
@dhalbert
Copy link
Collaborator Author

dhalbert commented Jun 28, 2020

.incoming_packet_length was added after 5.3.0, so unless we have another 5.x stable release, and then change the libraries, we can't drop .packet_size and have the libraries be backwards compatible without conditional code. We could defer this to 7.0.0, or put in conditional code.

The Adafruit libraries that use .packet_size now are:

@tannewt
Copy link
Member

tannewt commented Jun 30, 2020

I'm fine waiting for 7.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants