raspberrypi: Honor the requested offset= of a StateMachine#10010
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Jan 28, 2025
Merged
raspberrypi: Honor the requested offset= of a StateMachine#10010dhalbert merged 1 commit intoadafruit:mainfrom
dhalbert merged 1 commit intoadafruit:mainfrom
Conversation
The logic to do this was lost in my recent re-organization. Happily, just setting this field appropriately fixes it.
Author
|
Testing performed: I was using an implementation of quadrature encoder that required being loaded at address 0. It was loaded at address 4(?) instead, because loading at higher addresses is favored, and it didn't work. You can test with something like import array
import rp2pio
sm = rp2pio.StateMachine(array.array('H', [0]), 0, offset=1)
assert sm.offset == 1 |
dhalbert
approved these changes
Jan 28, 2025
Collaborator
dhalbert
left a comment
There was a problem hiding this comment.
Thanks for spotting this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to do this was lost in my recent re-organization. Happily, just setting this field appropriately fixes it.