Fix RP2350 Hang During storage.erase_filesystem#10111
Merged
tannewt merged 1 commit intoadafruit:mainfrom Mar 5, 2025
Merged
Conversation
|
I wonder whether this disable should be done inside supervisor_flash_pre_write & similar for the enable in post_write. |
jepler
approved these changes
Mar 5, 2025
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
I think this can go in as-is but some thought might be given to whether to move the disable/enable interrupts call, as my previous comment mentions.
Collaborator
Author
|
@jepler Absolutely. I'm preparing a second PR that I'll be submitting shortly that cleans up pre/post flash processing plus a few other minor issues in framebuffer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RP2350 would double-fault and hang-up during a
storage.erase_filesystem()with apicodvi.Framebufferobject active. Insupervisor_flash_init()a call toflash_do_command()was performed without disabling interrupts. Added needed calls to disable and enable interrupts.Resolves #10104.