Remove CIRCUITPY_8_9_WARNINGS and its usage.#10137
Conversation
tannewt
left a comment
There was a problem hiding this comment.
I think we actually want to enable this (and rename to CIRCUITPY_9_10_WARNINGS.)
In 10 we intended to remove these APIs and we want to start warning about it in 9.
circuitpython/shared-bindings/displayio/__init__.c
Lines 103 to 115 in b2752b3
|
These warnings were disabled because we added them too early. Following their advice broke compatibility with CP 8. Now that we're done with 8, we can enable it. Once main is CP 10 then we can remove the old APIs. |
|
Made changes requested by @tannewt: Renamed |
|
NB: In #9096, we disabled the warnings, because they were intrusive, and I aid we'd turn them back on when 8.x bundles were no longer being built. |
dhalbert
left a comment
There was a problem hiding this comment.
Tested and works as expected, with warnings showing when old bindings are used. Thanks!
Removes
CIRCUITPY_8_9_WARNINGSand its usage.Resolves #9596. Because the
CIRCUITPY_8_9_WARNINGSmacro was defined to(0)this change is ready to merge now.