py/builtinimport.c: always name module in error msg when an import fails#10629
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Sep 11, 2025
Merged
py/builtinimport.c: always name module in error msg when an import fails#10629dhalbert merged 1 commit intoadafruit:mainfrom
dhalbert merged 1 commit intoadafruit:mainfrom
Conversation
FoamyGuy
approved these changes
Sep 11, 2025
Collaborator
FoamyGuy
left a comment
There was a problem hiding this comment.
This looks good to me. I tested successfully on a TrinketM0 using a build from this branch and do see the complete error now:
code.py output:
Traceback (most recent call last):
File "code.py", line 5, in <module>
File "neopixel.py", line 17, in <module>
ImportError: no module named 'adafruit_pixelbuf'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the smallest boards, we use terse error messages to save space. Usually this is fine, but the
module not founderror is confusing, because on casual glance it can make it appear that a module being imported is missing, instead of some subsequent import being missing. Use the regular more verbose message instead, which names the missing module.I've seen several users be confused by this and resort to asking a support question. This happened most recently in discord.
Example and test:
Old way, which causes a number of users to say, "but I did add neopixel as a library":
Clearer message: