-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update tinyusb to fix gamepad;add HID OUT interface descriptor #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok. CI failed because STM files got shuffled around in the TinyUSB update.
@hierophect Note the change in 463415a. Now tinyusb distinguishes which STM32 USB device to support based on the origin (IP) of the USB device. In this case, |
@tannewt I fixed stm builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!
@dhalbert @tannewt Sadly, this has broken USB on the STM32F412, by excessively restricting the FS endpoints on that device. Also testing F411 which may suffer from the same issue. There are 6 FS endpoints on the F412, should be enough to support all circuitpython devices. Specific error:
|
Has something to do with the endpoint count. Could you loop me in as a reviewer next time you push an ST update? I'd like to help out with testing to help prevent issues like this. I didn't realize from the mention that this changed anything other than file names. |
@hierophect Sorry about this. Is this due to the OUT endpoint for HID? I thought this would not be an issue because it's the OUT half of an endpoint pair. |
@dhalbert |
@dhalbert My fix at the moment, by the way, is simply increasing the number of endpoints allowed by 1, and everything is working fine. |
Fixes #1696.
To use the XAC-compatible gamepad descriptor, add a line like this to, say,
ports/atmel-samd/boards/circuitplayground_express/mpconfigboard.mk
: