Skip to content

Fix crash after empty REPL session #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix crash after empty REPL session #2654

merged 1 commit into from
Feb 25, 2020

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Feb 25, 2020

We were trying to reset bluetooth when it was off and then trying
to raise an exception without the heap.

@tannewt
Fix crash after empty REPL session
28c7a1e 
We were trying to reset bluetooth when it was off and then trying
to raise an exception without the heap.
@tannewt tannewt added this to the 5.0.0 milestone Feb 25, 2020
@tannewt tannewt requested a review from dhalbert February 25, 2020 00:13
dhalbert
dhalbert approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The build failure is just one subjob that was a GitHub actions problem.

@dhalbert dhalbert merged commit 09ab24b into adafruit:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
bug crash nordic
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert