Skip to content

Fix socket.recv_into receiving one less byte than expected #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented Feb 7, 2021

Similar to #3955, recv_into (not SSL) only received len-1 bytes, when called with len.
Tested on a Lilygo TTGO T8 with a set of adafruit_requests, manual http get, and a websockets implementation.

@anecdata
Copy link
Member

anecdata commented Feb 7, 2021

Tested on FeatherS2 with current Requests. Fixes non-TLS LWIP HTTP: https://github.com/adafruit/Adafruit_CircuitPython_Requests/issues/71

@dhalbert dhalbert requested a review from tannewt February 8, 2021 16:23
@dhalbert
Copy link
Collaborator

dhalbert commented Feb 8, 2021

@tannewt Adding you for review since you worked on this.

@hierophect
Copy link
Collaborator

@Neradoc thanks for finding this. It's probably a carryover from the IDF's example code, which I should have fixed alongside #3955. Since @anecdata and I have both tested this should be good to go.

@hierophect hierophect merged commit 1043d61 into adafruit:main Feb 8, 2021
@Neradoc Neradoc deleted the fix-recv_into branch March 12, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants