fix for MX25R1635F QSPI mode of operation #4460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to most recent master
jepler
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Thank you! I don't have the hardware to verify, but I also noticed these changes bring things in line with the above MX25R6435F part.
The two devices still have a different start_up_time_us, not sure if important. If CircuitPython is loaded from a uf2 bootloader, as is customary on Adafruit boards, it does not matter.
@tannewt looks like you may need to pick up this change for nvm.toml.
|
@jepler Thank you for the review and merge actions! 800 us of 'start_up_time_us' is good enough. It is specified as a minimum value in the datasheet:
|
|
Excellent, thank you for that info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the MX25R1635F flash IC is connected to nRF52840 over quad-SPI bus - the CircuitPython does not boot.
Primary reason for that is incorrect 'quad_enable_bit_mask' definition used in current 'devices.h'
This is an excerpt from the datasheet:
For compatibility reasons with all the family of the MX25R1635F IC's and with all the modes of operation it is worth to lower SPI clock frequency down to 8 MHz:
This PR fixes the issue - it is confirmed that MX25R1635F is doing good in QSPI mode afterwards.