Skip to content

Implement issue #4470 #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Implement issue #4470 #4483

merged 2 commits into from
Mar 25, 2021

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented Mar 25, 2021

Moves the language allow list to build_board_info.py and use it with generate_download_info().
This syncs the list of languages on circuitpython.org with the builds.

I did some tests by adding a print of the generated json and using a test script digging into the data structure to compare it with the file generated from main (adding the same print to main), using beta and stable tags, checking that only the languages vary by what is expected.

Neradoc added 2 commits March 24, 2021 23:39
move the language allow list to generate_download_info() and use it there too
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you —This looks a lot like what I expected. Not merging because I hope @dhalbert will take a look too, and because CI's not through.

@jepler jepler requested a review from dhalbert March 25, 2021 02:40
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for doing this!

Minor Python thing: you can do return sorted(list(languages), key = lambda s: s.casefold()) as sorted(..., key=str.casefold). Not worth re-running for that, though.

@jepler jepler merged commit 47801bb into adafruit:main Mar 25, 2021
@Neradoc Neradoc deleted the implement-issue-4470 branch April 2, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants