Skip to content

OnDiskBitmap improvements #5017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2021
Merged

OnDiskBitmap improvements #5017

merged 3 commits into from
Jul 19, 2021

Conversation

jepler
Copy link

@jepler jepler commented Jul 19, 2021 •
edited
Loading

  • Fix out of memory write in constructor
  • Allow constructing from filename, rather than from open file object, to improve usability

Closes: #5008
Closes: #4197

jepler added 3 commits July 19, 2021 09:25
@jepler
OnDiskBitmap: Fix memory corruption when using palette image
2556fce 
The number of palette entries set was accidentally 4x too much,
because the wrong looping variable was used.
@jepler
OnDiskBitmap: Allow a filename to be passed to the constructor
1bbe728 
.. eventually we'll phase out the old way of constructing with an
open file, but this allows for compatibility between 6.x and 7.0.
@jepler
fix stubs
7896bf7
@jepler jepler requested a review from tannewt July 19, 2021 19:51
dhalbert
dhalbert approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with program in original issue, and also smoke-tested passing in a filename.

Thanks!

@dhalbert dhalbert merged commit b228891 into adafruit:main Jul 19, 2021
@cmora111
Copy link

sweet!! Thanks guys for all your efforts!!

@dhalbert dhalbert mentioned this pull request Jul 19, 2021
Closed
@jepler jepler deleted the ondiskbitmap branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OnDiskBitmap appears to be corrupting memory OnDiskBitmap fails quietly when file has been closed
3 participants
@jepler @cmora111 @dhalbert