Added Unique ID Functions/Updated Support Matrix by sommersoft · Pull Request #527 · adafruit/circuitpython

sommersoft · 2018-01-15T02:49:43Z

/shared-bindings/index.rst: updated Support Matrix format as discussed in PR #503 & Issue #448.

Issue #462 :
/shared-bindings/microcontroller/Processor.x:

Added functionality for retrieving the unique identifiers for all ports that support it.
Sphinx-rST documentation is in place, to include a note that the nRF port does not currently include struct for bytearray unpacking.

/ports/XXXX/common-hal/microcontroller/Processor.x:

Added functions to retreive unique identifiers for the following ports: SAMDxx, ESP8266, and nRF5x.
SAMD21 and SAMD51 use different memory addresses (handled in the function), whereas the nRF51x and nRF52x use the same memory addresses. ESP8266 uses the same functionality as machine.unique_id (which is still available).

P.S. I apologize for the merges/etc...trying to minimize the squashes necessary. Not sure I made that mark...

sommersoft · 2018-01-15T17:48:44Z

Hold of on merging. Just compiled on my new Feather M0 Express, and I'm getting some weird results:


Adafruit CircuitPython 3.0.0-alpha.1-62-g111faa1-dirty on 2018-01-15; Adafruit Feather M0 Express with samd21g18
>>> import microcontroller
>>> microcontroller.cpu.uid
bytearray(b'TRJ=\x01\x00\x00\x00(a\x00 @\x13\x00 ')
>>>

tannewt · 2018-01-15T17:51:27Z

Why is that result weird?

sommersoft · 2018-01-15T17:55:17Z

yeah, nevermind. I was actually getting errors on the struct.unpack...but now it isn't. must have been a case of "error: sommersoft did something wrong".


>>> import microcontroller
>>> import struct as struct
>>> print(struct.unpack('<i', microcontroller.cpu.uid))
(1028280916,)
>>>

tannewt

Getting close. Great work!

tannewt · 2018-01-15T17:54:08Z

ports/atmel-samd/common-hal/microcontroller/Processor.c

You'll need a loop within this one to save the four bytes of each uint32_t into four slots in raw_id.

tannewt · 2018-01-15T17:54:44Z

ports/nrf/common-hal/microcontroller/Processor.c

tannewt · 2018-01-15T17:59:46Z

shared-bindings/microcontroller/Processor.c

Just an oversight, please remove.

tannewt · 2018-01-15T18:00:40Z

shared-bindings/microcontroller/Processor.c

I wouldn't mention struct here. People can do what they want with it afterwards.

tannewt · 2018-01-15T19:02:39Z

shared-bindings/microcontroller/Processor.c

..attribute:: uid It should match the entry in mcu_processor_locals_dict_table below.

sommersoft · 2018-01-16T00:42:53Z

Changes made. SAMD tested on Feather M0 Express; nRF tested on Feather nRF52.

tannewt · 2018-01-16T04:13:07Z

Please rebase these onto latest master. Ping me on discord if you need help.

shared_bindings/index.rst: updated Support Matrix format as discussed in PR adafruit#503 & Issue adafruit#448.

shared-bindings/microcontroller/Processor.c & .h: added UID lookup functionality for use with all ports. See Issue adafruit#462.

ports/atmel-samd/common-hal/microcontroller/Processor.c & .h: added UID lookup function for SAMD ports. See Issue adafruit#462.

shared-bindings/index.rst: corrected term agreement/grammar for previous Support Matrix update. See PR adafruit#503 & Issue adafruit#448.

/esp8266/common-hal/microcontroller.h: added UID length definition

/esp8266/common-hal/microcontroller/Processor.c: added UID function

modified: ports/atmel-samd/common-hal/microcontroller/Processor.h modified: shared-bindings/microcontroller/Processor.c modified: shared-bindings/microcontroller/Processor.h

/ports/nrf/common-hal/microcontroller/Processor.h: add UID length definition.

/ports/nrf/common-hal/microcontroller/Processor.c: add UID function. See Issue adafruit#462.

/shared-bindings/microcontroller/Processor.c: added a note to `microcontroller.cpu.uid` (Issue adafruit#462) that ``struct`` is not currently available on the nRF port.

/ports/atmel-samd/common-hal/microcontroller.c: corrected `raw_id[]` assignment per requested changes in PR adafruit#527

/ports/nrf/common-hal/microcontroller.c: corrected `raw_id[]` assignment per requested changes in PR adafruit#527

/shared-bindings/microcontroller/Processor.c: corrected Sphinx documentation per requested changes in PR adafruit#527

tannewt

Code still looks good! Will wait for Travis and then merge.

tannewt requested changes Jan 15, 2018

View reviewed changes

tannewt previously approved these changes Jan 16, 2018

View reviewed changes

tannewt added this to the 3.0 milestone Jan 16, 2018

sommersoft and others added 15 commits January 16, 2018 23:19

modified: shared-bindings/index.rst

d430f01

shared_bindings/index.rst: updated Support Matrix format

02b4120

shared_bindings/index.rst: updated Support Matrix format as discussed in PR adafruit#503 & Issue adafruit#448.

shared-bindings/microcontroller/Processor.x: added UID

6dded2c

shared-bindings/microcontroller/Processor.c & .h: added UID lookup functionality for use with all ports. See Issue adafruit#462.

ports/atmel-samd/common-hal/microcontroller/: added UID

40d63dd

ports/atmel-samd/common-hal/microcontroller/Processor.c & .h: added UID lookup function for SAMD ports. See Issue adafruit#462.

shared-bindings/index.rst: corrected term agreement/grammar

d052296

shared-bindings/index.rst: corrected term agreement/grammar for previous Support Matrix update. See PR adafruit#503 & Issue adafruit#448.

/esp8266/common-hal/microcontroller.h: add uid

8780762

/esp8266/common-hal/microcontroller.h: added UID length definition

/esp8266/common-hal/microcontroller/Processor.c: add uid

dc4f02c

/esp8266/common-hal/microcontroller/Processor.c: added UID function

modified: ports/atmel-samd/common-hal/microcontroller/Processor.c

8babaf9

modified: ports/atmel-samd/common-hal/microcontroller/Processor.h modified: shared-bindings/microcontroller/Processor.c modified: shared-bindings/microcontroller/Processor.h

modified: ports/atmel-samd/common-hal/microcontroller/Processor.c

b6ddaba

modified: ports/atmel-samd/common-hal/microcontroller/Processor.h modified: shared-bindings/microcontroller/Processor.c modified: shared-bindings/microcontroller/Processor.h

/ports/nrf/common-hal/microcontroller/Processor.h: add UID

dc18aa3

/ports/nrf/common-hal/microcontroller/Processor.h: add UID length definition.

/ports/nrf/common-hal/microcontroller/Processor.c: add UID

a649a45

/ports/nrf/common-hal/microcontroller/Processor.c: add UID function. See Issue adafruit#462.

/shared-bindings/microcontroller/Processor.c: added nRF note

56689dc

/shared-bindings/microcontroller/Processor.c: added a note to `microcontroller.cpu.uid` (Issue adafruit#462) that ``struct`` is not currently available on the nRF port.

/ports/atmel-samd/common-hal/microcontroller.c: correction

3ef2077

/ports/atmel-samd/common-hal/microcontroller.c: corrected `raw_id[]` assignment per requested changes in PR adafruit#527

/ports/nrf/common-hal/microcontroller.c: correction

1457ce4

/ports/nrf/common-hal/microcontroller.c: corrected `raw_id[]` assignment per requested changes in PR adafruit#527

/shared-bindings/microcontroller/Processor.c: corrections

7e3f8b0

/shared-bindings/microcontroller/Processor.c: corrected Sphinx documentation per requested changes in PR adafruit#527

sommersoft dismissed tannewt’s stale review via 7e3f8b0 January 16, 2018 23:50

sommersoft force-pushed the master branch from 8ebd461 to 7e3f8b0 Compare January 16, 2018 23:50

tannewt approved these changes Jan 16, 2018

View reviewed changes

tannewt merged commit 44bc171 into adafruit:master Jan 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Unique ID Functions/Updated Support Matrix#527

Added Unique ID Functions/Updated Support Matrix#527
tannewt merged 15 commits intoadafruit:masterfrom
sommersoft:master

sommersoft commented Jan 15, 2018 •

edited

Loading

Uh oh!

sommersoft commented Jan 15, 2018

Uh oh!

tannewt commented Jan 15, 2018

Uh oh!

sommersoft commented Jan 15, 2018

Uh oh!

tannewt left a comment

Uh oh!

tannewt Jan 15, 2018

Uh oh!

tannewt Jan 15, 2018

Uh oh!

tannewt Jan 15, 2018

Uh oh!

tannewt Jan 15, 2018

Uh oh!

tannewt Jan 15, 2018

Uh oh!

sommersoft commented Jan 16, 2018

Uh oh!

tannewt commented Jan 16, 2018

Uh oh!

tannewt left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sommersoft commented Jan 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sommersoft commented Jan 15, 2018

Uh oh!

tannewt commented Jan 15, 2018

Uh oh!

sommersoft commented Jan 15, 2018

Uh oh!

tannewt left a comment

Choose a reason for hiding this comment

Uh oh!

tannewt Jan 15, 2018

Choose a reason for hiding this comment

Uh oh!

tannewt Jan 15, 2018

Choose a reason for hiding this comment

Uh oh!

tannewt Jan 15, 2018

Choose a reason for hiding this comment

Uh oh!

tannewt Jan 15, 2018

Choose a reason for hiding this comment

Uh oh!

tannewt Jan 15, 2018

Choose a reason for hiding this comment

Uh oh!

sommersoft commented Jan 16, 2018

Uh oh!

tannewt commented Jan 16, 2018

Uh oh!

tannewt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sommersoft commented Jan 15, 2018 •

edited

Loading