Skip to content

Delete out of date docs, drivers and examples#632

Merged
dhalbert merged 2 commits intoadafruit:2.xfrom
tannewt:delete_out_of_date
Feb 22, 2018
Merged

Delete out of date docs, drivers and examples#632
dhalbert merged 2 commits intoadafruit:2.xfrom
tannewt:delete_out_of_date

Conversation

@tannewt
Copy link
Member

@tannewt tannewt commented Feb 21, 2018

@tannewt tannewt added this to the 3.0 milestone Feb 21, 2018
@tannewt tannewt requested review from dhalbert and willingc February 21, 2018 02:13
Copy link

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely beautiful @tannewt. Did an in-depth review of rendered docs. Skimmed the code.

@willingc
Copy link

Leaving for @dhalbert's eagle eyes before merge.

@dhalbert
Copy link
Collaborator

When I do a search in https://tannewt-circuitpython.readthedocs.io/en/delete_out_of_date/ for things like busio or DigitalInOut, they don't show up, and I can't find them in the left sidebar. Is that build OK?

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just the one question.

@tannewt
Copy link
Member Author

tannewt commented Feb 22, 2018

That build was getting the wrong conf.py. I cleared up everything and it looks better. https://tannewt-circuitpython.readthedocs.io/en/delete_out_of_date/docs/index.html

This changed some too: https://tannewt-circuitpython.readthedocs.io/en/delete_out_of_date/docs/library/index.html

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants