extmod/vfs_fat_file: Implement SEEK_CUR for non-zero offset.#697
Merged
tannewt merged 1 commit intoadafruit:masterfrom Mar 23, 2018
Merged
extmod/vfs_fat_file: Implement SEEK_CUR for non-zero offset.#697tannewt merged 1 commit intoadafruit:masterfrom
tannewt merged 1 commit intoadafruit:masterfrom
Conversation
CPython doesn't allow SEEK_CUR with non-zero offset for files in text mode, and uPy inherited this behaviour for both text and binary files. It makes sense to provide full support for SEEK_CUR of binary-mode files in uPy, and to do this in a minimal way means also allowing to use SEEK_CUR with non-zero offsets on text-mode files. That seems to be a fair compromise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this functionality was now added in uPy and cherry-picked the fix.
As far as testing goes, there is an added test case but unfortunately it looks like the related test is skipped during the unix and qemu builds.☹️
Closes: #501