Increase the memory for the lwip stack #7416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a speeculative fix for adafruit#7346. The theory is that having some active socket objects uses up the small (4000-byte) pool reserved for lwip and prevents mdns from operating properly. However, as I wasn't able to reproduce the problem with the given script, this is just a guess.
|
The Pico W still drops off the list of CircuitPython devices when |
|
#7589 is probably the real fix. It was sort of surprising mdns worked at all without it. |
|
OK, I will close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speeculative fix for #7346. The theory is that having some active socket objects uses up the small (4000-byte) pool reserved for lwip and prevents mdns from operating properly. However, as I wasn't able to reproduce the problem with the given script, this is just a guess.
@RetiredWizard testing with artifacts from this PR would be appreciated, if you're able to do so!