(u)binascii: better python3 compatibility#788
Merged
tannewt merged 3 commits intoadafruit:masterfrom May 2, 2018
Merged
Conversation
.. some of these tests currently fail, but a subsequent commit will fix them.
…lity .. this maybe should be subject to MICROPY_CPYTHON_COMPAT, except that is not defined in the main circuitpython ports so it would be a change that makes no difference.
tannewt
added
enhancement
circuitpython api
cpython api
tannewt
requested changes
May 1, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
One quick change and then it looks good.
py/objmodule.c
Outdated
Member
There was a problem hiding this comment.
Lets remove the MicroPython version so folks don't use it and break compatibility.
tannewt
approved these changes
May 2, 2018
Member
|
Please comment on a PR when you want to me to take another look. Thanks for the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the python3 compatibility of the 'ubinascii' module as it relates to treatment of unicode (not bytes) inputs and aliases it as 'binascii'. It adds additional tests for bytes vs unicode behavior.