Human readable OSError messages for low flash devices#891
Merged
tannewt merged 4 commits intoadafruit:masterfrom Jun 5, 2018
Merged
Human readable OSError messages for low flash devices#891tannewt merged 4 commits intoadafruit:masterfrom
tannewt merged 4 commits intoadafruit:masterfrom
Conversation
b97cfdd to
0f4280a
Compare
We can provide a basic version of mp_errno_to_str even if the uerrno module won't be provided. Rather than looking errno names up in the uerrno module's globals dict, we'll just rely on a simple mapping in the function itself.
The uerrno module was written to allow boards to customize the list of errnos they can raise. Start by copying the default list.
Remove errnos that are only raised by modules that aren't linked into the atmel-samd port.
0f4280a to
22f4438
Compare
tannewt
approved these changes
Jun 5, 2018
Member
tannewt
left a comment
There was a problem hiding this comment.
Yay! This looks great. Nice and clean. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#837 implemented human readable
OSErrormessages, but excluded low-flash devices (ones withBOARD_FLASH_SIZE <= 192000).This PR improves the situation on those devices:
On devices with low flash, we still won't create the
uerrnomodule. Instead, we'll create a utility method that knows how to map each of the errno's that we can raise to its name. In order to save flash, we also prune the list of errno's that the utility method must know about down to just the subset that can be raised on atmel-samd.