Use the external crystal on SAMD21 again.#892
Merged
dhalbert merged 1 commit intoadafruit:masterfrom Jun 2, 2018
Merged
Conversation
Also, re-enable calibration storage for CircuitPlayground Express. Tested with a 500hz PWMOut on Metro M0 with Saleae: * with crystal 500hz * with usb 500hz +- 0.1hz * without either 487hz += 0.1hz SAMD51 is skipped due to DFLL errata and the fact it defaults to a factory calibrated 48mhz that works fine for USB. Fixes micropython#648
notro
reviewed
Jun 2, 2018
notro
left a comment
notro
left a comment
There was a problem hiding this comment.
Looks good, but for me a Circuit Playground Express build didn't fit in the flash:
-44 bytes free in flash out of 253440 bytes ( 247.5 kb ).
4084 bytes free in ram for stack out of 32768 bytes ( 32.0 kb ).
Too little flash!!!
Collaborator
|
@notro Thaks - We encountered the CPX overflow last night and are working on shrinking things. I reduced the size of the one of the frozen libraries by several hundred bytes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, re-enable calibration storage for CircuitPlayground Express.
Tested with a 500hz PWMOut on Metro M0 with Saleae:
SAMD51 is skipped due to DFLL errata and the fact it defaults to a
factory calibrated 48mhz that works fine for USB.
Fixes #648