Skip to content

Devcontainer update#9068

Merged
dhalbert merged 6 commits intoadafruit:mainfrom
bablokb:devcontainer_update
Mar 22, 2024
Merged

Devcontainer update#9068
dhalbert merged 6 commits intoadafruit:mainfrom
bablokb:devcontainer_update

Conversation

@bablokb
Copy link

@bablokb bablokb commented Mar 21, 2024

This adds support for Github-codespaces for CP 9.x.x.

It fixes #9029.

Another major change is that the devcontainer-alternatives are now on a per port basis (major speedup in codespace creation since the codespace only fetches submodules relevant to the selected port). Currently only ports using espressif and cortex-m are supported.

@dhalbert
Copy link
Collaborator

You should be able to use pre-commit locally to catch these: https://learn.adafruit.com/building-circuitpython/build-circuitpython#install-pre-commit-3096511

@bablokb
Copy link
Author

bablokb commented Mar 21, 2024

The problem is that trailing whitespace is valid markup (two trailing blanks signal a line break), so I think you should change pre-commit. Anyhow, I removed the whitespace so this is fine now.

@dhalbert
Copy link
Collaborator

I think it would be better to use <br> in general: it's valid markdown and is not invisible like trailing whitespace. But no problem here now.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it would be good to write this up in https://adafruit-playground.com/. I could link to that from the "Building CircuitPython" guide and/or at least link to the Readme here.

@bablokb
Copy link
Author

bablokb commented Mar 21, 2024

it would be good to write this up in https://adafruit-playground.com/.

Yes, that is on my todo-list.

@dhalbert dhalbert merged commit 50ad62d into adafruit:main Mar 22, 2024
@bablokb
Copy link
Author

bablokb commented Mar 23, 2024

@dhalbert
Copy link
Collaborator

@bablokb I have added a page in the Building CircuitPython guide that points to your Playground note. I will also blog it on the Adafruit blog.

@dhalbert
Copy link
Collaborator

@bablokb bablokb deleted the devcontainer_update branch March 27, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.devcontainer: Uses incorrect ARM toolchain version

2 participants