Runtime.serial_bytes_available: return count instead of bool#9141
Merged
tannewt merged 2 commits intoadafruit:mainfrom Apr 5, 2024
Merged
Runtime.serial_bytes_available: return count instead of bool#9141tannewt merged 2 commits intoadafruit:mainfrom
tannewt merged 2 commits intoadafruit:mainfrom
Conversation
tannewt
requested changes
Apr 4, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
A couple functional questions. Thanks for cleaning this up!
dhalbert
changed the title
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
supervisor.Runtime.serial_bytes_availableto return the number of available bytes instead of just a True or False. Since0isFalse-y, this works in the common case ofif supervisor.runtime.serial_bytes_available:.I looked in the Learn Guides and I only found one use of
.serial_bytes_available, and it's exactly as above.This was a much larger change than one might think because I did a refactor to reduce a bunch of identical
common-hal/supervisorfiles to single files insupervisor/shared. So there is, net, a lot less code now.