synthio: Calculate LFO.value at construction#9247
Merged
dhalbert merged 1 commit intoadafruit:mainfrom May 18, 2024
Merged
Conversation
jepler
changed the title
Originally, the only (non-debug) way to make an LFO calculate its value was to associate it with a playing synthesizer. This posed a problem for LFOs that had "power on values" other than 0, and where the value was used other than to internally drive a note property. Now, an initial, possibly non-zero value is calculated at object construction time: ```py >>> l = synthio.LFO(offset = 1) >>> l.value 1.0 ``` Note that this happens just once at construction; it does not happen when updating LFO properties: ```py >>> l.offset = 2 >>> l.value 1.0 ```
jepler
force-pushed
the
improve-lfo-initial-value
branch
from
a0b55ec to
9e878f7
Compare
gamblor21
approved these changes
May 17, 2024
Member
gamblor21
left a comment
gamblor21
left a comment
There was a problem hiding this comment.
Tried on an UM FeatherS2, worked as expected.
dhalbert
approved these changes
May 18, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks, and @gamblor21, thanks for testing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the only (non-debug) way to make an LFO calculate its value was to associate it with a playing synthesizer.
This posed a problem for LFOs that had "power on values" other than 0, and where the value was used other than to internally drive a note property.
Now, an initial, possibly non-zero value is calculated at object construction time:
Note that this happens just once at construction; it does not happen when updating LFO properties:
ping @kevinjwalters