Use micropython-uncrustify from pypi instead of apt package#9295
Merged
dhalbert merged 2 commits intoadafruit:mainfrom Jun 3, 2024
Merged
Use micropython-uncrustify from pypi instead of apt package#9295dhalbert merged 2 commits intoadafruit:mainfrom
dhalbert merged 2 commits intoadafruit:mainfrom
Conversation
Collaborator
Author
|
I'm mystified why builds were working before without the |
jepler
approved these changes
Jun 3, 2024
jepler
left a comment
There was a problem hiding this comment.
Makes sense. Do docs or learn need to be updated too?
Collaborator
Author
Worth checking. I looked, and not that I can see. |
|
it was specifically https://learn.adafruit.com/building-circuitpython/linux#install-build-tools-on-ubuntu-2986713 that I wondered about, but you must have updated it already. thanks! |
|
there may be a couple of references left in the source tree to the apt/dpkg-based installation method: origin/main:.devcontainer/common_tools.sh:sudo apt-get -y install uncrustify mtools
origin/main:ports/silabs/README.md: sudo apt install default-jre gcc-arm-none-eabi wget python3 python3-pip git git-lfs gettext uncrustify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MicroPython depends on a particular version of
uncrustifyto format its C code. This version is available from https://launchpad.net/~pybricks/+archive/ubuntu/ppa, but not for Ubuntu 24.04. A.debfrom a previous version could be installed, but that's not necessarily a long-term solution. (The long-term solution is to update to a newer version of uncrustify.)See https://github.com/orgs/micropython/discussions/14496 for background.
The maintainer of that PPA has now created a PyPi package for that version of
uncrustify: https://pypi.org/project/micropython-uncrustify/. The repo for that is here: https://github.com/dlech/micropython-uncrustify.This PR switches to installing that uncrustify by putting it in
requirements-dev.txt.If and when MicroPython switches to a newer uncrustify, we can undo this.