Skip to content

New board version: Nano 33 BLE Rev2#9347

Merged
dhalbert merged 6 commits intoadafruit:mainfrom
applecuckoo:applecuckoo-nano-33-ble
Jun 19, 2024
Merged

New board version: Nano 33 BLE Rev2#9347
dhalbert merged 6 commits intoadafruit:mainfrom
applecuckoo:applecuckoo-nano-33-ble

Conversation

@applecuckoo
Copy link

This is a quick addition to define a couple of interrupt pins only available on the second revision of the Arduino Nano 33 BLE Sense. In a way, this is to close my own issue, #7991.

I figured that since there weren't any pin-related breaking changes between the two revisions, it was better to add to the existing definition.
This is only based on pin diagrams since I don't have the actual hardware to test this.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo fixes in the description.

I think it would be better for this to be a new board definition. It's a new product with a new stock number: https://store.arduino.cc/products/nano-33-ble-sense-rev2. A new entry (by PR)would be added to circuitpython.org as well. Assuming so, take the _V2 off the pin names.

@applecuckoo applecuckoo requested a review from dhalbert June 19, 2024 08:34
@dhalbert dhalbert changed the title Revise Arduino Nano 33 BLE definition to include pins for the Nano 33 BLE Sense Rev2 New board version: Nano 33 BLE Sense Rev2 Jun 19, 2024
@dhalbert
Copy link
Collaborator

Could you also prepare a PR to add this new board to circuitpython.org? See https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website. Thanks!

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I touched up the duplicate PID list by adding a comma to fix the build error. Looks fine now. I'll merge, and you can go ahead and submit a PR to the circuitpython-org repo.

@dhalbert dhalbert merged commit 3645e81 into adafruit:main Jun 19, 2024
@applecuckoo applecuckoo changed the title New board version: Nano 33 BLE Sense Rev2 New board version: Nano 33 BLE Rev2 Jun 20, 2024
@applecuckoo
Copy link
Author

I've opened a PR for the website - see adafruit/circuitpython-org#1426

@applecuckoo applecuckoo deleted the applecuckoo-nano-33-ble branch June 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants