remove UART object and use pins for IR#9389
Merged
dhalbert merged 2 commits intoadafruit:mainfrom Jul 1, 2024
bradanlane:bls_rp2040_explorer_uart
Merged
remove UART object and use pins for IR#9389dhalbert merged 2 commits intoadafruit:mainfrom bradanlane:bls_rp2040_explorer_uart
dhalbert merged 2 commits intoadafruit:mainfrom
bradanlane:bls_rp2040_explorer_uart
Conversation
dhalbert
requested changes
Jul 1, 2024
ports/raspberrypi/boards/bradanlanestudio_explorer_rp2040/mpconfigboard.h
Show resolved
Hide resolved
Comment on lines
20
to
+25
| FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Display_Text | ||
| FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Display_Shapes | ||
| FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_HID | ||
| FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_IRRemote | ||
| FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_asyncio | ||
| FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_Ticks |
Collaborator
There was a problem hiding this comment.
Alphabetize these for ease of finding things.
Comment on lines
41
to
43
| // GPIO0 and GPIO1 are used for IR and not for UART | ||
| { MP_ROM_QSTR(MP_QSTR_TX), MP_ROM_PTR(&pin_GPIO0) }, | ||
| { MP_ROM_QSTR(MP_QSTR_RX), MP_ROM_PTR(&pin_GPIO1) }, |
Collaborator
There was a problem hiding this comment.
How about renaming these, because TX and RX are traditionally used for UART? On CPX and other boards, we use these names:
Suggested change
| // GPIO0 and GPIO1 are used for IR and not for UART | |
| { MP_ROM_QSTR(MP_QSTR_TX), MP_ROM_PTR(&pin_GPIO0) }, | |
| { MP_ROM_QSTR(MP_QSTR_RX), MP_ROM_PTR(&pin_GPIO1) }, | |
| { MP_ROM_QSTR(MP_QSTR_IR_TX), MP_ROM_PTR(&pin_GPIO0) }, | |
| { MP_ROM_QSTR(MP_QSTR_IR_ RX), MP_ROM_PTR(&pin_GPIO1) }, |
| { MP_ROM_QSTR(MP_QSTR_GP28), MP_ROM_PTR(&pin_GPIO28) }, | ||
| // GPIO28 is also the interrupt pin of the accelerometer | ||
| { MP_ROM_QSTR(MP_QSTR_ACCEL_INT), MP_ROM_PTR(&pin_GPIO28) }, | ||
| // GPIO28 is also the interrupt pin of the accelerometer on some boards |
Collaborator
There was a problem hiding this comment.
THe GPIO28 pin alias was removed. Was that intentional? If so remove the line 114 comment.
Comment on lines
117
to
118
| // GPIO29 is also the ID value of the board (an analog read value between 0 .. 4096) | ||
| // { MP_ROM_QSTR(MP_QSTR_VID), MP_ROM_PTR(&pin_GPIO29) }, |
Collaborator
There was a problem hiding this comment.
If this is not true anymore, just remove.
Suggested change
| // GPIO29 is also the ID value of the board (an analog read value between 0 .. 4096) | |
| // { MP_ROM_QSTR(MP_QSTR_VID), MP_ROM_PTR(&pin_GPIO29) }, |
Author
|
I made requested changes. the comments in pins.h have been updated and remain relevant for future maintenance of the code. |
dhalbert
approved these changes
Jul 1, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
OK, thanks for for the changes!
Author
|
I continue to get email notifications on this PR for "Build CI / mpy-cross-mac" failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RP2040 Explorer Badge used traditional IR capabilities. These use GP0 and GP1 which were previously anticipated to be exposed for UART. They are no longer exposed as pins and are dedicated to the RI emitter and IR receiver.