Update pins.c for m5dial

[mumin50]

Hi All my first pull request ever :)
I just realised i miss SDA and SCL pins for M5Dial NFC reader, it is connected directly to board.I2C but in some usages having those pins will make things easier to work with busio

[mumin50]

Tested on my side - compiled and working ok
`Adafruit CircuitPython 9.1.0-beta.4-2-gc64bdf2c74 on 2024-07-04; M5Stack Dial with ESP32S3

import board
dir(board)
['class', 'name', 'A1', 'A2', 'BOOT0', 'BUTTON', 'D0', 'D1', 'D13', 'D15', 'D2', 'DISPLAY', 'ENC_A', 'ENC_B', 'I2C', 'KNOB_BUTTON', 'MOSI', 'NEOPIXEL', 'PORTA_I2C', 'PORTB_IN', 'PORTB_OUT', 'POWER_HOLD', 'RFID_IRQ', 'RFID_SCL', 'RFID_SDA', 'SCK', 'SCL', 'SDA', 'SPEAKER', 'SPI', 'TFT_BACKLIGHT', 'TFT_CS', 'TFT_DC', 'TFT_RESET', 'TOUCH_IRQ', 'dict', 'board_id']
`

Tested with my library code - also working
`code.py output:
i2c initialized
Place card before reader to read from address 0x08
New card detected

• tag type: 0x10
• uid : 0x8804851b`

[dhalbert]

I'm not sure of the naming here. board.PORTA_I2C() uses the GPIO13/15 for its SDA/SCL. But those pins are board.SDA and board.SCL. Normally board.I2C would use board.SDA and board.SCL. But here board.I2C() uses board.RFID_SDA and board.RFID_SCL.

From mpconfigboard.h:

#define CIRCUITPY_BOARD_I2C_PIN     {{.scl = &pin_GPIO12, .sda = &pin_GPIO11}, \
                                     {.scl = &pin_GPIO15, .sda = &pin_GPIO13}}

Are board.RFID_SDA and board.RFID_SCL broken out for general use, or are they strictly internal for the RFID? If the latter, then I'd suggest board.RFID_I2C() for them, and board.I2C() for the Port A SDA and SCL instead.

[dhalbert]

@CDarius You did the original naming. What do you think?

[CDarius]

The board.I2C() (pins 11 and 12) is internal (not broken out) but it serves two peripherals: RFID and RTC.
I agree that having pin 13 board.SDA and pin 15 board.SCL on board.PORTA_I2C() may be confusing.
I suggest the following changes:

• Rename board.SDA in board.PORTA_SDA (pin 13)
• Rename board.SCL in board.PORTA_SCL (pin 15)
• Add board.SDA on pin 11
• Add board.SCL on pin 12

[mumin50]

I just also realised it is used for other devices on I2C so probably naming is wrong. Sorry i was only using RFID for now so perchaps like CDarius mentioned would be better.
Just tell when i gladly do the testing .

[dhalbert]

@CDarius' suggestion makes sense to me, as it is consistent with m5stack_paper and some other m5stack boards. There are also some examples of a different naming scheme with SYS_i2C, but there are more boards with the plain I2C() as the internal one, so we can stick with that.

[dhalbert]

I made the changes. @mumin50 and @CDarius, could you double-check that this is OK?

[dhalbert]

I double-checked so I'll go ahead and merge.

[CDarius]

@dhalbert I little late but I looked at your changes and they look good to me

[mumin50]

Works ok thank You