Fix docstring for stdout.buffer#9556
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Aug 23, 2024
timdechant:dev_stdio_docstring
Merged
Fix docstring for stdout.buffer#9556dhalbert merged 1 commit intoadafruit:mainfrom timdechant:dev_stdio_docstring
dhalbert merged 1 commit intoadafruit:mainfrom
timdechant:dev_stdio_docstring
Conversation
Earlier commit changed stdio docstring/type to StringIO and included stdio_buffer_obj in that. Reviewing history for that object, it is intended to implement (e.g.) stdout.buffer, which is a binary stream. Revert back to FileIO for that docstring/type.
dhalbert
approved these changes
Aug 23, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks for re-checking!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep
stdoutasStringIO, but revertstdout.buffertype back toFileIO.Earlier commit changed stdio docstring/type to StringIO and included stdio_buffer_obj in that. Reviewing history for that object, it is intended to implement (e.g.) stdout.buffer, which is a binary stream.