Upload merged PR's to AWS for x.x.x branches#9557
Merged
dhalbert merged 1 commit intoadafruit:9.1.xfrom Aug 25, 2024
Merged
Conversation
Collaborator
Author
|
Huzzah, it worked! From S3:
Sorry to bypass the approval checking, but I thought I was going to have to debug this and run the approval merge several times. |
tannewt
reviewed
Aug 27, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Fine with me. Thanks for adding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only merged PR's to main are uploaded to https://adafruit-circuit-python.s3.amazonaws.com/index.html?prefix=bin. This is an attempt to upload merges for all branches ending in
.x, so9.1.x, etc.The string operations available in
ifstatements in the CI yaml files are limited. There are ways to do regexp, etc., that involve generating a result and then using it, but it's clumsier. However, I think doing it for*.xbranches is probably good enough.Only way to test this is to merge it, I think.
I'm trying to use extra indentation in the
if:to make it easier to read. Not sure if that will work.