add support for new custom board - CircuitArt ESP32S3 zero#9593
Merged
tannewt merged 6 commits intoadafruit:mainfrom Sep 4, 2024
CircuitART:main
Merged
add support for new custom board - CircuitArt ESP32S3 zero#9593tannewt merged 6 commits intoadafruit:mainfrom CircuitART:main
tannewt merged 6 commits intoadafruit:mainfrom
CircuitART:main
Conversation
fixed: add space after the comments operator (//)
added space after the comment operator (//)
removed unsupported frozen lib
tannewt
requested changes
Sep 4, 2024
Member
tannewt
left a comment
There was a problem hiding this comment.
What happened to the Feather S3 that you requested the PID for? It is weird you are reusing it.
typo mistake Co-authored-by: Scott Shawcroft <scott@tannewt.org>
Author
|
my Feather S3 project was canceled and replaced with the zero version, I opened new pull request in espressif pid requesting changes on the pid name as well |
Author
|
@tannewt just thought to let u know know that Espressif-pid has been changed successfully |
Member
|
Thank you @CircuitART |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a custom board that i developed it using the same footprint as pi zero.
the PID was obtained from Espressif espressif/usb-pids#33
I have already build and tested circuitpython on it, and so far all is good