Implement more ESP BLE Descriptor support#9597
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Sep 5, 2024
Merged
Conversation
BLE HID was broken because the descriptor wasn't marked as readable. This fixes micropython#9430. Also add read/write support for client. Servers can only set the initial value. Setting it later will raise a NotImplementedError. Setting a user_description will also raise a NotImplementedError. This can help us find cases that use it.
dhalbert
approved these changes
Sep 5, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Tested HID with an iPhone. Works! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BLE HID was broken because the descriptor wasn't marked as readable. This fixes #9430.
Also add read/write support for client. Servers can only set the initial value. Setting it later will raise a NotImplementedError.
Setting a user_description will also raise a NotImplementedError. This can help us find cases that use it.