shared/runtime/sys_stdio_mphal: Fix docstring for stdio.#9598
Merged
dhalbert merged 6 commits intoadafruit:mainfrom Sep 9, 2024
timdechant:micropython-merge
Merged
shared/runtime/sys_stdio_mphal: Fix docstring for stdio.#9598dhalbert merged 6 commits intoadafruit:mainfrom timdechant:micropython-merge
dhalbert merged 6 commits intoadafruit:mainfrom
timdechant:micropython-merge
Conversation
Signed-off-by: timdechant <timdechant.git@gmail.com>
Signed-off-by: timdechant <timdechant.git@gmail.com>
Signed-off-by: timdechant <timdechant.git@gmail.com>
Signed-off-by: timdechant <timdechant.git@gmail.com>
Signed-off-by: timdechant <timdechant.git@gmail.com>
dhalbert
approved these changes
Sep 5, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Thanks! It was good to get Damien's take on this.
dhalbert
requested changes
Sep 5, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
The Metro M0 build German build is overflowing by 16 bytes. Tomorrow I will see about shrinking this build slightly. The other build failures are transient CI issues.
Author
|
Thanks, Dan! And thanks for all your work here, it's a great project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporating
stdiorecommendations from micropython#15708.