Work around an sdk bug (fixes rotaryio on RP2350)#9682
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Oct 4, 2024
Merged
Work around an sdk bug (fixes rotaryio on RP2350)#9682dhalbert merged 1 commit intoadafruit:mainfrom
dhalbert merged 1 commit intoadafruit:mainfrom
Conversation
This was already reported & fixed upstream, but the fix will not be in a released SDK until 2.0.1. It's easy enough to use our own workaround. Testing: without this bug fix, rotaryencoder did not work on a pico 2 Note: the cut&paste code was reindented by uncrustify, giving it a slightly different style than the upstream sdk code.
Collaborator
|
Looks like pico-sdk 2.0.1 might be next week, if I am interpreting this correctly: raspberrypi/pico-sdk#1877 (comment) |
dhalbert
approved these changes
Oct 4, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
I tested with an RP2350 and also an RP2040 (to check for any regression). Both work with the test program. Thanks!
dhalbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already reported & fixed upstream, but the fix will not be in a released SDK until 2.0.1. It's easy enough to use our own workaround.
Testing: without this bug fix, rotaryencoder did not work on a pico 2
Note: the cut&paste code was reindented by uncrustify, giving it a slightly different style than the upstream sdk code.
Closes: #9681
I thought I had PRd this two weeks ago, but apparently I didn't. The problem was independently rediscovered by @D3Fq, thanks for the report.