Added basic Espressif PDM microphone support #7454#9828
Merged
tannewt merged 3 commits intoadafruit:mainfrom Dec 2, 2024
Merged
Added basic Espressif PDM microphone support #7454#9828tannewt merged 3 commits intoadafruit:mainfrom
tannewt merged 3 commits intoadafruit:mainfrom
Conversation
Member
|
Code looks reasonable to me. I say keep going. :-) Thanks! |
Author
|
I think the CI failures are due to the code being compiled for boards that don't support it. I may be missing some guard macros. I'll take a look soon. |
…on boards that don't support PDMIn.
Author
|
Okay adding guard macros has allowed the CI checks to pass. Should this be merged? I'm not sure what remains to be done. |
tannewt
approved these changes
Dec 2, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Yup! I think this is fine. Thank you!
Author
|
Thanks! Will someone handle closing #7454? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic PDM microphone support to the Espressif port. Only the most basic functionality has been tested: 16-bit, monophonic input seems to generate appropriate data when viewed in the Arduino plotter.
Support required adding implementations in
ports/espressif/common-hal/audiobusio/PDMIn.[c|h], as well as a change toshared-bindings/audiobusio/PDMIn.cto allow for clean deinit of underlying ESP-IDF objects.This PR is not intended to be complete, I just wanted to get it in front of more people to get feedback.