Support .NET Core SDK 3.1.300 and later #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamralph
changed the title
This was referenced May 26, 2020
| } | ||
| } | ||
| " | ||
| ); |
There was a problem hiding this comment.
I'm late to the party, but here's a simpler way:
dotnet new globaljson --sdk-version 3.1.300 --force
There was a problem hiding this comment.
Thanks @thomaslevesque!
BTW why would I need the --force option?
There was a problem hiding this comment.
To overwrite the existing file, like your current code is doing
This was referenced May 31, 2020
0xced
added a commit
to serilog-contrib/serilog-formatting-log4net
that referenced
this pull request
Sep 21, 2020
It is required for both MinVer and SourceLink to work properly. See adamralph/minver#347 and dotnet/sdk#10614
This was referenced Sep 28, 2020
Merged
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core SDK 3.1.300 contains a breaking change which results in projects versioned with MinVer producing assemblies which do not have the correct
AssemblyFileVersion,AssemblyInformationalVersion, andAssemblyVersion. Effectively, these versions are not set, and will keep their default values, which are usually1.0.0.0,1.0.0, and1.0.0.0respectively.Note that only assembly versions are affected. If a project produces a NuGet package, the version of the package is still correct. However, the problem with assembly versions means that, effectively, MinVer 2.2.0 and earlier do not support .NET Core SDK 3.1.300 and later.
This enhancement adds support for .NET Core SDK 3.1.300 and later in MinVer 2.3.0.
Thanks to @ghorsey and @joacar for spotting this and raising #342 and #343 respectively, and thanks to @bording for fixing this in #344, which was cherry-picked into this branch.