Use Windows_SDK.json from UE to determine what VS components to install

[slonopotamus]

This is just a draft of how I would like to install VS so it matches what engine expects.

Closes #372

Closes #381

Closes #375

Closes #350

---

Changes are not properly tested yet. For engines older than 5.4 that do not have Windows_SDK.json, I plan to hardcode fallback setup, like we do currently.

@TBBle @adamrehn @Alexey31rus what do you think?

---

Engines tested so far: 5.2, 5.3, 5.4 5.5, 5.6

[slonopotamus]

Well. This PR successfully builds 5.6.1.

I'm going to restore pre-5.4 compatibility (when Windows_SDK.json didn't exist) and then test all engines...

[slonopotamus]

There is one problem with these changes - Build Tools are not present in ue4-minimal because it is copied on top of ue4-build-prerequisites.

[jonpas]

I don't remember having to need this. Or is this because of the newer SDK?

[slonopotamus]

I actually do not remember, this was too many moons ago :D But I definitely hit this when was testing 5.2 in current PR.

[jonpas]

Needs Avalanche patch and PixelStreaming patch for unreachable code with Visual Studio 17.10 at least. Unsure about others.

Avalanche patch

diff --git a/Engine/Plugins/Experimental/Avalanche/Source/AvalancheViewport/Private/Interaction/AvaCameraZoomController.cpp b/Engine/Plugins/Experimental/Avalanche/Source/AvalancheViewport/Private/Interaction/AvaCameraZoomController.cpp
index b5ce8a64b2fc3..4ff4fd49c02db 100644
--- a/Engine/Plugins/Experimental/Avalanche/Source/AvalancheViewport/Private/Interaction/AvaCameraZoomController.cpp
+++ b/Engine/Plugins/Experimental/Avalanche/Source/AvalancheViewport/Private/Interaction/AvaCameraZoomController.cpp
@@ -238,8 +238,8 @@ void FAvaCameraZoomController::CenterOnPoint(const FVector2f& InPoint)
 
 void FAvaCameraZoomController::CenterOnBox(const FBox& InBoundingBox, const FTransform& InBoxTransform)
 {
-	// TODO @Update
-	return;
+	// @TODO Update
+#if 0
 
 	TSharedPtr<IAvaViewportClient> AvaViewportClient = AvaViewportClientWeak.Pin();
 
@@ -313,6 +313,7 @@ void FAvaCameraZoomController::CenterOnBox(const FBox& InBoundingBox, const FTra
 	SetZoomLevel(RequiredZoomLevel - 1);
 	ZoomIn();
 	CenterOnPoint(ScreenBoundsCenter);
+#endif
 }
 
 void FAvaCameraZoomController::StartPanning()

PixelStreaming patch

diff --git a/Engine/Plugins/Media/PixelStreaming/Source/PixelStreaming/Private/PixelStreamingModule.cpp b/Engine/Plugins/Media/PixelStreaming/Source/PixelStreaming/Private/PixelStreamingModule.cpp
index 15d4bfe494432..d98d0e1b669a9 100644
--- a/Engine/Plugins/Media/PixelStreaming/Source/PixelStreaming/Private/PixelStreamingModule.cpp
+++ b/Engine/Plugins/Media/PixelStreaming/Source/PixelStreaming/Private/PixelStreamingModule.cpp
@@ -70,6 +70,7 @@ namespace UE::PixelStreaming
 	/**
 	 * IModuleInterface implementation
 	 */
+	PRAGMA_DISABLE_UNREACHABLE_CODE_WARNINGS
 	void FPixelStreamingModule::StartupModule()
 	{
 #if UE_SERVER
@@ -155,6 +156,7 @@ namespace UE::PixelStreaming
 		FStats::Get();
 		bStartupCompleted = true;
 	}
+	PRAGMA_RESTORE_UNREACHABLE_CODE_WARNINGS
 
 	void FPixelStreamingModule::ShutdownModule()
 	{

[jonpas]

This patch was required for me last time I built 5.5 as well.

diff --git a/Engine/Plugins/Media/BlackmagicMedia/Source/BlackmagicCore/Private/BlackmagicInputChannel.h b/Engine/Plugins/Media/BlackmagicMedia/Source/BlackmagicCore/Private/BlackmagicInputChannel.h
index 58927eb8962e0..a52039a022c41 100644
--- a/Engine/Plugins/Media/BlackmagicMedia/Source/BlackmagicCore/Private/BlackmagicInputChannel.h
+++ b/Engine/Plugins/Media/BlackmagicMedia/Source/BlackmagicCore/Private/BlackmagicInputChannel.h
@@ -3,6 +3,7 @@
 #pragma once
 
 #include "Common.h"
+#include <chrono>
 
 namespace BlackmagicDesign
 {

[jonpas]

This patch is not required anymore (5.6.1)?

diff --git a/Engine/Plugins/Experimental/AvalancheDataLink/AvalancheDataLink.uplugin b/Engine/Plugins/Experimental/AvalancheDataLink/AvalancheDataLink.uplugin
index ad8ee3d6b5c2c..884a731e16539 100644
--- a/Engine/Plugins/Experimental/AvalancheDataLink/AvalancheDataLink.uplugin
+++ b/Engine/Plugins/Experimental/AvalancheDataLink/AvalancheDataLink.uplugin
@@ -17,7 +17,8 @@
 		{
 			"Name": "AvalancheDataLink",
 			"Type": "Runtime",
-			"LoadingPhase": "Default"
+			"LoadingPhase": "Default",
+			"TargetDenyList": [ "Server" ]
 		},
 		{
 			"Name": "AvalancheDataLinkEditor",

[slonopotamus]

@jonpas Unfortunately, you're linking some private repo that I do not have access to (even though I have access to UnrealEngine repo).

[jonpas]

Ah sorry, forgot Unreal repos are private and linked from our fork with cherry-picked patches applied. Maybe links work now, but I also added the diffs in case they still don't (I didn't go search in upstream repo).

[jonpas]

What is the status on this? Anything that would help speed this along?

[slonopotamus]

What is the status on this?

I still need to reorganize multi-staging a bit so we do not lose VS in ue4-minimal image.

[jonpas]

Let me know if I can be of any help. I can spin up some resources to test builds.