Adding per collection custom delimiter#36
Merged
adbario merged 3 commits intoadbario:2.xfrom Oct 14, 2022
mattsah:2.x
Merged
Conversation
adbario
reviewed
Oct 14, 2022
src/Dot.php
Outdated
| public function __construct($items = [], $delimiter = '.') | ||
| { | ||
| $this->items = $this->getArrayItems($items); | ||
| $this->delimiter = $delimiter; |
Owner
There was a problem hiding this comment.
If the delimiter is an empty string, explode() will throw an error. So the delimiter must default to a dot if an empty string was passed to the constructor.
adbario
approved these changes
Oct 14, 2022
Owner
|
Thanks for the contribution @mattsah 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request for 2.x (for a v2.5) to add the custom delimiter at the constructor (per collection) level only per #35.