Registry-Lookup should not expect assetKind and assetType as mandatory input

[ChrisKoerber]

What happens?

With #46 assetKind and assetType were introduced in the AAS descriptor as well as in the GetAllAssetAdministrationShellDescriptors operation.

The lookup operation expects them to be mandatory input parameters, which in my opinion should not be the case. They should be optional, allowing general lookups on all available descriptors as well as more specific lookups like stated in the original issue description of @BirgitBoss.

This issue is valid for v3.0 up to v3.0.2 of the Part 2 specification.

Why is this wrong?

As the original issue states assetKind and assetType might OFTEN be used for lookup - but not necessarily ALWAYS.

Furthermore properties are specified optional in the descriptor. So this makes conformant descriptor useless (if missing assetKind and assetType ) since they cannot be used for lookup.

How should it be fixed?

Change the input parameters assetKind and assetType of GetAllAssetAdministrationShellDescriptors to be optional.
By the way - this is how BaSyx currently implements the interface anyway ;)

[BirgitBoss]

thank your for your finding: you are right, the specification documentation seems to be buggy.

It should be
assetKind Mand. no Card. 1
assetType Mand. no Card. 1

However, the swagger definition seems correct:

https://app.swaggerhub.com/apis/Plattform_i40/AssetAdministrationShellRegistryServiceSpecification/V3.0.2_SSP-001#/Asset%20Administration%20Shell%20Registry%20API/GetAllAssetAdministrationShellDescriptors

[sebbader-sap]

Thanks for reporting! It's indeed only affecting the specification.

[sebbader-sap]

Fix is also included in V3.0.3