#445: Relaxed api to not throw 404 when element was not found on PUT #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgordtop
requested review from
sebbader-sap,
BirgitBoss,
aorzelskiGH,
mjacoby,
danielporta,
g1zzm0,
getag,
waltersve and
zrgt
as code owners
BirgitBoss
requested changes
May 15, 2025
…tifiable services
BirgitBoss
reviewed
May 23, 2025
| @@ -44,7 +44,7 @@ paths: | |||
| put: | |||
| tags: | |||
| - Asset Administration Shell API | |||
| summary: Creates or updates an existing Asset Administration Shell | |||
| summary: Updates an existing Asset Administration Shell | |||
There was a problem hiding this comment.
Here 201 return code missing?
There was a problem hiding this comment.
Yes, that is intentionally - for all "Service" interfaces (the one targetting a single identifiable, I removed the update again. These services offer no POST - so I thought it makes no sense to introduce a create via the backdoor.
I understand the services interfaces as interfaces for single objects - they do not offer the option to create new objects (an IOT device offers data via aas interface - but doesn't allow "huckepack" objects). If so, it would offer a repository interface...
BirgitBoss
reviewed
May 23, 2025
Entire-API-Collection/V3.1.yaml
Outdated
| @@ -1632,6 +1645,8 @@ paths: | |||
| $ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.0#/components/schemas/Submodel' | |||
| required: true | |||
| responses: | |||
| '201': | |||
| description: Submodel created successfully | |||
There was a problem hiding this comment.
Here without ?
description: Concept Description created successfully
headers:
Location:
description: URL of the newly created resource
schema:
type: string
content:
application/json:
schema:
$ref: 'https://api.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.1.0#/components/schemas/ConceptDescription'
BirgitBoss
reviewed
May 23, 2025
Entire-API-Collection/V3.1.yaml
Outdated
| @@ -3312,7 +3349,7 @@ paths: | |||
| put: | |||
| tags: | |||
| - Asset Administration Shell Repository API | |||
| summary: Creates or updates the Submodel | |||
| summary: Updates the Submodel | |||
There was a problem hiding this comment.
why only update and not create or update?
BirgitBoss
reviewed
May 23, 2025
documentation/IDTA-01002-3/modules/ROOT/pages/specification/interfaces.adoc
Outdated
Show resolved
Hide resolved
BirgitBoss
reviewed
May 23, 2025
| @@ -71,7 +71,7 @@ e|payload a|Requested Asset Administration Shell |yes | link:https://admin-shell | |||
| [width=100%,cols="25%,35%,10%,20%,10%"] | |||
| |=== | |||
| h|*Operation Name* 4+e|[[PutAssetAdministrationShell]]PutAssetAdministrationShell | |||
| hh|Explanation 4+a|Replaces the Asset Administration Shell | |||
| h|Explanation 4+a|Replaces the Asset Administration Shell or create it if it does not exist | |||
There was a problem hiding this comment.
Suggested change
| h|Explanation 4+a|Replaces the Asset Administration Shell or create it if it does not exist | |
| h|Explanation 4+a|Replaces the Asset Administration Shell or creates it if it does not exist |
BirgitBoss
approved these changes
May 23, 2025
BirgitBoss
merged commit b99a121
into
admin-shell-io:IDTA-01002-3-1_preparation
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.