-
Notifications
You must be signed in to change notification settings - Fork 2
Initial version #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… don't exit the sync job as it may get fixed later
👍 |
1 similar comment
👍 |
"runtime" | ||
"runtime/pprof" | ||
"time" | ||
// "net/http" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove please
@ddragosd 🤘 after the comments. I'll create an issue to use sync from the go AWS SDK, I really don't like executing aws s3 sync from the command line. |
@adragomir I've also started initially at integrating a library as opposed to executing a command line. I've picked rclone as it comes with broader support, it's not just for AWS. There are 2 problems with
So at the moment I don't have a solution to support multiple clouds and integrate it as a lib, but I agree with you that it would be a nicer implementation. |
``` { status: "OK", lastSync: "2016-02-24T23:10:36.148512004-08:00", lastChangeDetected: "2016-02-24T23:07:36.036041758-08:00", lastReload: "2016-02-24T23:07:41.041648492-08:00" } ```
@selfxp @clehene @adragomir I've added unit tests and along with them I've enriched the (updated) Sample output for the health-check API:
Let me know what you think. |
👍 |
rclone
. Note thatrclone
doesn't work yet with IAM Roles and this is why we're using AWS cli.