Update connector-ldap.yml #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include some more comments for all_users_filter
adobeDan
suggested changes
Sep 26, 2017
| # In order to obtain a more fine-tunned list of LDAP users, adapt the filter to your needs. | ||
| # Only resulted users from this filter predicate are ever considered by the User Sync tool; | ||
| # that is, all LDAP queries issued by User Sync include this predicate to filter out LDAP resources | ||
| # that are not subject of synchronization. |
There was a problem hiding this comment.
Your wording is not idiomatic english and needs to be changed. How about:
Use this filter to control exactly which LDAP resources are considered for synchronization.
If a user is not accepted by this filter he will never be seen by the User Sync tool, even if
your command line specifies --users all or he is in a group you have specified in your
command line (--users group g1) or in your configuration file (for group mapping).
Wording change for all_users_filter
adobeDan
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included some more comments for all_users_filter