prepare for v2.3rc1 release #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic working Okta Connector
Okta Example Config and Minor change to connector_okta.py
…nto bhunut-adobe-okta
Fixed Multiple Group found issue with Okta Connector
…ith latest change
Updated identitytype to identity_type
…a.py according to adobeDan's feedback
Mostly this was a clean merge. The following areas needed some work: * documentation (adding Okta as a supported connector) * example configuration files (standardizing the format) * the `--connector` argument (now supports all three types of connectors, and correctly interacts with the `--users` argument) * the Makefile (remove the wheelhouse, and put the supporting okta module into the external directory) # Conflicts: # Makefile # docs/user-manual/index.md # setup.py # user_sync/app.py
This required: * Updating the supporting "okta" import to by fully py3-compatible. The sources are now at https://github.com/adobe-apiplatform/okta-sdk.py . * Updating one of the tests which was py2-specific in terms of string type and hash order.
Integrate Okta connector for 2.3 release
Callers of create_umapi_commands_for_directory_user should be prepared for a None result.
This fixes: * the okta connector key was being reported as ignored when not used. * okta connector's `load_users_and_groups` didn't have the current full set of arguments. * clean up error messages for okta-produced errors * py2/py3 differences in the definition of `filter` led to uncaught errors in py3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.