enforce country code to be uppercase #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correcting Issue #
Resolving issue #319 by enforcing the value to be always uppercase
adobeDan
suggested changes
Dec 15, 2017
| @@ -269,9 +269,9 @@ def iter_users(self, users_filter, extended_attributes): | |||
| if sn_value is not None: | |||
| user['lastname'] = sn_value | |||
| c_value = LDAPValueFormatter.get_attribute_value(record, six.text_type('c')) | |||
| source_attributes['c'] = c_value | |||
| source_attributes['c'] = c_value.upper() if c_value else None | |||
There was a problem hiding this comment.
The source_attributes should not be uppercased, because it's supposed to show through the actual source value.
|
changes applied; also for Okta |
adobeDan
suggested changes
Dec 15, 2017
| else: | ||
| source_attributes['countryCode'] = None | ||
| source_attributes['countryCode'] = user['country'] = None |
There was a problem hiding this comment.
No, the field on the user object is not supposed to be set in this case; only the source object. This line should stay the same.
|
Sorry, I just thought it was a missed users['country'] assignment to None since, following the logic for source_attributes in directory_ldap file. I did not follow where these variable go after.. |
adobeDan
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolving issue #319
This change is proposed for csv and ldap only.