Ability to disable paged results for Enterprise Directory #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Simple Page Mode Control ( 1.2.840.113556.1.4.319) is not supported. Use search_page_size: 0 to disable paged results from Enterprise Directory
bajwa-adobe
changed the title
adobeDan
suggested changes
Jan 10, 2018
| if search_page_size == 0: | ||
| msgid = connection.search(base_dn, scope, | ||
| filterstr=filter_string, attrlist=attributes) | ||
| result_type, response_data, _rmsgid = connection.result2(msgid) |
There was a problem hiding this comment.
I think you need to set msgid = None here after retrieving results to avoid problems at GeneratorExit should one be thrown. There's no connection to abandon in this case.
Set msgid = None after getting results
adobeDan
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Simple Page Mode Control ( 1.2.840.113556.1.4.319) is not supported.
Use search_page_size: 0 to disable paged results from Enterprise
Directory
#324 UST throws error 'Critical extension is unavailable' for oracle directory that does not support Simple Page Mode Control